fix: exposed-bom module missing when publishing #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `exposed-bom` module was missing when `0.42.0` was published because its `build.gradle.kts` file was missing the necessary setup that has credentials and the Space respository URL to publish to. So this setup was copied over from `publishing.gradle.kts`.
joc-a
force-pushed
the
joc/include-exposed-bom-in-publishing
branch
from
6ed4bbb
to
b34c4a2
Compare
joc-a
changed the title
e5l
approved these changes
Aug 4, 2023
| @@ -31,13 +31,32 @@ dependencies { | |||
| } | |||
|
|
|||
| publishing { | |||
| val version: String by rootProject | |||
There was a problem hiding this comment.
Not sure if I'm doing something wrong, but there is a type mismatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
exposed-bommodule was missing when0.42.0was published because itsbuild.gradle.ktsfile was missing the necessary setup that has credentials and the Space respository URL to publish to. So this setup was copied over frompublishing.gradle.kts.exposed-bomis now already published at the time of writing. A temporary branch was used for the Deploy build config in TeamCity (checked out from this commit74fba00a77dce1d12cafad722064db2f5aeff84ebecause it was the last one used when0.42.0was released) that includes one more commit with the same changes in this PR, in addition to other changes to prevent re-publishing the other modules and allow publishing onlyexposed-bomthis time.The changes in this PR are sufficient to include
exposed-bomin the next release without any additional work on TeamCity.