Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: EXPOSED-124 Add Spring Boot samples #1826

Merged
merged 18 commits into from
Sep 12, 2023

Conversation

FullOfOrange
Copy link
Contributor

@FullOfOrange FullOfOrange commented Aug 8, 2023

Add sample spring boot 3 project at /sample directory

  • use exposed-spring-boot-starter module
  • use h2 database

@FullOfOrange FullOfOrange changed the title [EXPOSED-124] Add Spring Boot samples docs: [EXPOSED-124] Add Spring Boot samples Aug 8, 2023
@FullOfOrange FullOfOrange changed the title docs: [EXPOSED-124] Add Spring Boot samples docs: EXPOSED-124 Add Spring Boot samples Aug 8, 2023
@FullOfOrange
Copy link
Contributor Author

I'll fix detekt issues tomorrow

@bog-walk
Copy link
Member

bog-walk commented Sep 6, 2023

@FullOfOrange Based on what I'm seeing so far, is it correct to say that the upcoming changes to SpringTransactionManager won't require any updates/changes to this sample?
We can delay merging this sample until that PR is finalized, or I can start the review process for this now.

@bog-walk bog-walk self-assigned this Sep 6, 2023
@FullOfOrange
Copy link
Contributor Author

@bog-walk This sample is not affected by the changes in SpringTransactionManager! You can review it right away.

@bog-walk bog-walk requested a review from e5l September 10, 2023 14:36
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please address minor issue

samples/exposed-spring/build.gradle.kts Show resolved Hide resolved
@bog-walk bog-walk merged commit 5199654 into JetBrains:main Sep 12, 2023
2 checks passed
saral pushed a commit to saral/Exposed that referenced this pull request Oct 3, 2023
* Add spring sample

* add: readme files

* chore: fix detekte issues

* chore: fix detekt isuses

* chore: fix detekt issue

* chore: empty commit for build

* chore: bump up exposed version to 0.43.0

* docs: Add some comments in cods

* docs: Update README.md

* chore: fix detekt issue

* chore: fix detekt issue

* fix: detekt issue

* fix: import ordering

* fix: fit kotlin version to other ktor samples

* fix: remove needless empty line

* refactor: apply jvm toolchain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants