fix: EXPOSED-122 Fix timestampWithTimeZone tests in Oracle #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following test fails when run on Oracle in the 3 modules: exposed-kotlin-datetime, exposed-java-time, exposed-jodatime DefaultsTest/testTimestampWithTimeZoneDefaults The following tests fail when run on Oracle in exposed-jodatime only: JodaTimeBaseTest/testTimestampWithTimeZone JodaTimeMiscTableTest/testTimestampWithTimeZone Issue 1: Fails with: ORA-01861: literal does not match format string Because Oracle is set to use the default formatter (2023-08-09T11:26:32.7367231Z) instead of the expected pattern (2023-08-09 11:26:32.7367231 +00:00). Oracle now has its own datetime formatter in each module. Issue 2: In exposed-jodatime module only, reading a timestamp with time zone object in Oracle then fails with a NPE. This occurs because of a read conversion error since DateTime is sent to the DB as java.sql.Timestamp and ends up being stored as oracle.sql.TIMESTAMPTZ. The object is instead read and retrieved as a java.sql.Timestamp.
joc-a
approved these changes
Aug 9, 2023
saral
pushed a commit
to saral/Exposed
that referenced
this pull request
Oct 3, 2023
…#1829) The following test fails when run on Oracle in the 3 modules: exposed-kotlin-datetime, exposed-java-time, exposed-jodatime DefaultsTest/testTimestampWithTimeZoneDefaults The following tests fail when run on Oracle in exposed-jodatime only: JodaTimeBaseTest/testTimestampWithTimeZone JodaTimeMiscTableTest/testTimestampWithTimeZone Issue 1: Fails with: ORA-01861: literal does not match format string Because Oracle is set to use the default formatter (2023-08-09T11:26:32.7367231Z) instead of the expected pattern (2023-08-09 11:26:32.7367231 +00:00). Oracle now has its own datetime formatter in each module. Issue 2: In exposed-jodatime module only, reading a timestamp with time zone object in Oracle then fails with a NPE. This occurs because of a read conversion error since DateTime is sent to the DB as java.sql.Timestamp and ends up being stored as oracle.sql.TIMESTAMPTZ. The object is instead read and retrieved as a java.sql.Timestamp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following test fails when run on Oracle in the 3 modules:
exposed-kotlin-datetime,exposed-java-time,exposed-jodatimeDefaultsTest/testTimestampWithTimeZoneDefaults()
The following tests also fail when run on Oracle, but in
exposed-jodatimeonly:JodaTimeBaseTest/testTimestampWithTimeZone()
JodaTimeMiscTableTest/testTimestampWithTimeZone()
Issue 1:
Fails with:
ORA-01861: literal does not match format stringBecause Oracle is set to use the default formatter, instead of the accepted pattern:
Oracle now has its own datetime formatter in each module.
Issue 2:
In
exposed-jodatimemodule only, reading a timestamp with time zone object in Oracle then fails with a NPE at this line:rs.getObject(index, offsetDateTimeClass).This occurs because of a read conversion error since
DateTimeis sent to the DB asjava.sql.Timestampand ends up being stored asoracle.sql.TIMESTAMPTZ.The object is instead read and retrieved as a
java.sql.Timestamp.