fix: EXPOSED-137 SET DEFAULT reference option should not be supported in Oracle #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following test fails when run on Oracle: sqlite/ForeignKeyConstraintTests/'test ON DELETE SET DEFAULT for databases that support it without SQLite'() Fails with: java.sql.SQLException: ORA-03001: unimplemented feature Oracle's ON DELETE clause only supports CASCADE or SET NULL reference options. A warning is now logged and the option is not appended to the query string.
joc-a
approved these changes
Aug 9, 2023
e5l
approved these changes
Aug 10, 2023
saral
pushed a commit
to saral/Exposed
that referenced
this pull request
Oct 3, 2023
…JetBrains#1830) The following test fails when run on Oracle: sqlite/ForeignKeyConstraintTests/'test ON DELETE SET DEFAULT for databases that support it without SQLite'() Fails with: java.sql.SQLException: ORA-03001: unimplemented feature Oracle's ON DELETE clause only supports CASCADE or SET NULL reference options. A warning is now logged and the option is not appended to the query string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following test fails when run on Oracle:
sqlite/ForeignKeyConstraintTests/'test ON DELETE SET DEFAULT for databases that support it without SQLite'()
Fails with:
Oracle's ON DELETE clause only supports CASCADE or SET NULL reference options (documentation).
A warning is now logged instead of appending to the query string and Oracle is excluded from relevant tests.