fix: EXPOSED-151 Quoted identifiers cause incorrect schema validation #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a table object is created with user-quoted table and/or column name, unnecessary CREATE and ALTER statements are generated by SchemaUtils validation functions. This happens because returned metadata does not include quotes (except MySQL), so comparisons with cached identifiers gives false results. Ensuring that functions in SchemaUtils, JdbcDatabaseMetadataImpl, and Table.exists() use the correct table or column name without quotes allows more accurate equality checks.
e5l
approved these changes
Aug 24, 2023
joc-a
approved these changes
Aug 24, 2023
saral
pushed a commit
to saral/Exposed
that referenced
this pull request
Oct 3, 2023
…JetBrains#1842) If a table object is created with user-quoted table and/or column name, unnecessary CREATE and ALTER statements are generated by SchemaUtils validation functions. This happens because returned metadata does not include quotes (except MySQL), so comparisons with cached identifiers gives false results. Ensuring that functions in SchemaUtils, JdbcDatabaseMetadataImpl, and Table.exists() use the correct table or column name without quotes allows more accurate equality checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a table object is created with user-quoted table and/or column names, attempting to validate it using either
SchemaUtils.createMissingTablesAndColumns()orSchemaUtils.statementsRequiredToActualizeScheme()incorrectly generates CREATE and ALTER statements.This happens because metadata returned by the database does not generally include quotes.
So any comparison check with the cached identifiers (which do include quotes) in
Table.exists()orSchemaUtilsfunctions causes false negative results.Table and column functions that process/unquote the respective names are introduced to ensure a more accurate equality check with metadata.