fix: Remove false warning log #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bog-walk
approved these changes
Aug 24, 2023
exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/ResultRow.kt
Outdated
Show resolved
Hide resolved
joc-a
force-pushed
the
joc/remove-false-warning-log
branch
from
b7b75bc
to
eeda917
Compare
-This warning was first eliminated here https://github.com/JetBrains/Exposed/pull/541/files. Then it was accidentally introduced again here 77f11a9 because of the change made to the getOrNull function. -A new dependency was added (io.github.hakky54:logcaptor) to assert that no logging took place
joc-a
force-pushed
the
joc/remove-false-warning-log
branch
from
2d6db81
to
499173b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning was first eliminated here. Then it was accidentally introduced again here because of the change made to the
getOrNullfunction.To fix this, I moved the logic in the
getfunction to a new function,getInternal, that has a Boolean parametercheckNullabilitywhich it uses to decide to whether or not to check for the column's nullability and log a warning.A new test dependency was added (io.github.hakky54:logcaptor) to assert that no logging took place.