fix: EXPOSED-161 SQL Server syntax incorrectly allows CASCADE with dropSchema #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bog-walk
commented
Aug 31, 2023
exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/vendors/SQLServerDialect.kt
Show resolved
Hide resolved
e5l
approved these changes
Sep 4, 2023
exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/vendors/SQLServerDialect.kt
Show resolved
Hide resolved
…opSchema Using dropSchema() with cascade set to true in SQL Server throws a syntax excep> because cascade is not supported. Edit syntax to remove cascade. Add unit test.
…opSchema Remove unused import
…opSchema Add KDocs comment about cascade flag
bog-walk
force-pushed
the
bog-walk/fix-sqlserver-drop-cascade
branch
from
d2afc1f
to
e05d1a0
Compare
saral
pushed a commit
to saral/Exposed
that referenced
this pull request
Oct 3, 2023
…opSchema (JetBrains#1850) * fix: EXPOSED-161 SQL Server syntax incorrectly allows CASCADE with dropSchema Using dropSchema() with cascade set to true in SQL Server throws a syntax exception because cascade is not supported. Edit syntax to remove cascade. Add unit test. Add KDocs comment about cascade flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
SchemaUtils.dropSchema(schema, cascade = true)is used with SQL Server it fails with the error:Documentation shows that CASCADE is not supported in this statement (from version 2016 upwards).
In fact, other uses of
dropSchema()with cascade make sure to exclude SQL Server: