Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EXPOSED-162 SQLite generatedKeys exception #1854

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

joc-a
Copy link
Collaborator

@joc-a joc-a commented Sep 6, 2023

Support for getGeneratedKeys() was dropped in the sqlite jdbc version 3.43.0.0. This caused a SQLFeatureNotSupportedException when using this version with Exposed, so the old implementation of getGeneratedKeys() was used to retain the previous behaviour.

@joc-a joc-a force-pushed the joc/fix-sqlite-generated-keys-exception branch 4 times, most recently from 0cd4a28 to ec74743 Compare September 12, 2023 15:27
Support for getGeneratedKeys() was dropped in the sqlite jdbc version 3.43.0.0. This caused a SQLFeatureNotSupportedException when using this version with Exposed, so the old implementation of getGeneratedKeys() was used in Exposed to retain the previous behaviour.
@joc-a joc-a force-pushed the joc/fix-sqlite-generated-keys-exception branch from ec74743 to 383ac7d Compare September 12, 2023 21:16
@joc-a joc-a marked this pull request as ready for review September 14, 2023 07:44
@joc-a joc-a requested review from e5l and bog-walk September 14, 2023 07:44
@joc-a joc-a merged commit fe85d93 into main Sep 18, 2023
3 checks passed
@joc-a joc-a deleted the joc/fix-sqlite-generated-keys-exception branch September 18, 2023 10:35
saral pushed a commit to saral/Exposed that referenced this pull request Oct 3, 2023
Support for getGeneratedKeys() was dropped in the sqlite jdbc version 3.43.0.0. This caused a SQLFeatureNotSupportedException when using this version with Exposed, so the old implementation of getGeneratedKeys() was used in Exposed to retain the previous behaviour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants