fix: EXPOSED-117 Set jvmToolchain to 8 for all modules #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bog-walk
approved these changes
Sep 12, 2023
e5l
force-pushed
the
e5l/jvm-toolchain
branch
from
7b68f10
to
00eac07
Compare
|
Replaced usage of jdk9 api in tests, @bog-walk please take a look |
bog-walk
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Looks good.
ConnectionPoolTests are failing to start because HikariCP 5.0.2 needs jdk11+.
Works fine locally if HikariCP is dropped to 4.0.3.
saral
pushed a commit
to saral/Exposed
that referenced
this pull request
Oct 3, 2023
* fix: EXPOSED-117 Set jvmToolchain to 8 for all modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix EXPOSED-117