fix: EXPOSED-179 Unsigned column check constraint is not unique to table #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bog-walk
force-pushed
the
bog-walk/fix-unsigned-check-constraint
branch
from
17345fb
to
1f74bd3
Compare
joc-a
approved these changes
Sep 19, 2023
e5l
approved these changes
Sep 21, 2023
Auto-generated name for check constraint on unsigned column types was not including table name, which was problematic if multiple tables used identical column types with the same name. The check constraint name now includes the table name, unsigned type, and column name, which should avoid intra-/inter-table naming exceptions.
Clean up new unti test.
bog-walk
force-pushed
the
bog-walk/fix-unsigned-check-constraint
branch
from
1f74bd3
to
7114268
Compare
saral
pushed a commit
to saral/Exposed
that referenced
this pull request
Oct 3, 2023
…ble (JetBrains#1860) * fix: EXPOSED-179 Unsigned column check constraint is not unique to table Auto-generated name for check constraint on unsigned column types was not including table name, which was problematic if multiple tables used identical column types with the same name. The check constraint name now includes the table name, unsigned type, and column name, which should avoid intra-/inter-table naming exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple tables have the same unsigned column types with the same column names, creating these tables throws
JdbcSQLSyntaxErrorExceptionwith a message likeName already used by existing constraint.Affected databases: H2 (+ compatibility modes), SQL Server, Oracle.
To avoid these naming clashes, the name of the auto-generated check constraint for the unsigned column types now includes the table name in the prefix, with the original column type and name appended to it.