Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: EXPOSED-173 UPDATE_RULE read incorrectly for Oracle #1865

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix: EXPOSED-173 UPDATE_RULE read incorrectly for Oracle #1865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...dbc/src/main/kotlin/org/jetbrains/exposed/sql/statements/jdbc/JdbcDatabaseMetadataImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,9 @@ class JdbcDatabaseMetadataImpl(database: String, val metadata: DatabaseMetaData)
val targetColumn = allTables[targetTableName]?.columns?.firstOrNull {
identifierManager.quoteIdentifierWhenWrongCaseOrNecessary(it.nameInDatabaseCase()) == targetColumnName
} ?: return@iterate null // Do not crash if there are missing fields in Exposed's tables
val constraintUpdateRule = ReferenceOption.resolveRefOptionFromJdbc(getInt("UPDATE_RULE"))
val constraintUpdateRule = getObject("UPDATE_RULE")?.toString()?.toIntOrNull()?.let {
ReferenceOption.resolveRefOptionFromJdbc(it)
}
val constraintDeleteRule = ReferenceOption.resolveRefOptionFromJdbc(getInt("DELETE_RULE"))
ForeignKeyConstraint(
target = targetColumn,
Expand Down
87 changes: 84 additions & 3 deletions ...tests/src/test/kotlin/org/jetbrains/exposed/sql/tests/sqlite/ForeignKeyConstraintTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import org.jetbrains.exposed.sql.*
import org.jetbrains.exposed.sql.SqlExpressionBuilder.eq
import org.jetbrains.exposed.sql.tests.DatabaseTestsBase
import org.jetbrains.exposed.sql.tests.TestDB
import org.jetbrains.exposed.sql.tests.currentDialectTest
import org.jetbrains.exposed.sql.tests.shared.Category
import org.jetbrains.exposed.sql.tests.shared.DEFAULT_CATEGORY_ID
import org.jetbrains.exposed.sql.tests.shared.Item
Expand All @@ -27,7 +28,13 @@ class ForeignKeyConstraintTests : DatabaseTestsBase() {
fun `test ON DELETE SET DEFAULT for SQLite`() {
Assume.assumeTrue(TestDB.SQLITE in TestDB.enabledDialects())

transaction(Database.connect("jdbc:sqlite:file:test?mode=memory&cache=shared&foreign_keys=on", user = "root", driver = "org.sqlite.JDBC")) {
transaction(
Database.connect(
"jdbc:sqlite:file:test?mode=memory&cache=shared&foreign_keys=on",
user = "root",
driver = "org.sqlite.JDBC"
)
) {
testOnDeleteSetDefault()
}
}
Expand Down Expand Up @@ -80,7 +87,13 @@ class ForeignKeyConstraintTests : DatabaseTestsBase() {
fun `test ON DELETE RESTRICT for SQLite`() {
Assume.assumeTrue(TestDB.SQLITE in TestDB.enabledDialects())

transaction(Database.connect("jdbc:sqlite:file:test?mode=memory&cache=shared&foreign_keys=on", user = "root", driver = "org.sqlite.JDBC")) {
transaction(
Database.connect(
"jdbc:sqlite:file:test?mode=memory&cache=shared&foreign_keys=on",
user = "root",
driver = "org.sqlite.JDBC"
)
) {
testRestrict(isTestingOnDelete = true)
}
}
Expand All @@ -96,7 +109,13 @@ class ForeignKeyConstraintTests : DatabaseTestsBase() {
fun `test ON UPDATE RESTRICT for SQLite`() {
Assume.assumeTrue(TestDB.SQLITE in TestDB.enabledDialects())

transaction(Database.connect("jdbc:sqlite:file:test?mode=memory&cache=shared&foreign_keys=on", user = "root", driver = "org.sqlite.JDBC")) {
transaction(
Database.connect(
"jdbc:sqlite:file:test?mode=memory&cache=shared&foreign_keys=on",
user = "root",
driver = "org.sqlite.JDBC"
)
) {
testRestrict(isTestingOnDelete = false)
}
}
Expand Down Expand Up @@ -150,4 +169,66 @@ class ForeignKeyConstraintTests : DatabaseTestsBase() {
}
}
}

@Test
fun testUpdateRuleReadCorrectlyWhenNotSpecifiedInChildTable() {
val category = object : Table("Category") {
val id = integer("id")

override val primaryKey = PrimaryKey(id)
}

val item = object : Table("Item") {
val id = integer("id")
val categoryId = integer("categoryId").references(category.id)

override val primaryKey = PrimaryKey(id)
}

withTables(category, item) { testDb ->
if (currentDialectTest.supportsOnUpdate) {
val constraints = connection.metadata {
tableConstraints(listOf(item))
}
constraints.values.forEach { list ->
list.forEach {
when (testDb) {
TestDB.H2_ORACLE, TestDB.H2_SQLSERVER ->
assertEquals(ReferenceOption.RESTRICT, it.updateRule)
else -> assertEquals(currentDialectTest.defaultReferenceOption, it.updateRule)
}
}
}
}
}
}

@Test
fun testUpdateRuleReadCorrectlyWhenSpecifiedInChildTable() {
val category = object : Table("Category") {
val id = integer("id")

override val primaryKey = PrimaryKey(id)
}

val item = object : Table("Item") {
val id = integer("id")
val categoryId = integer("categoryId").references(category.id, onUpdate = ReferenceOption.CASCADE)

override val primaryKey = PrimaryKey(id)
}

withTables(category, item) {
if (currentDialectTest.supportsOnUpdate) {
val constraints = connection.metadata {
tableConstraints(listOf(item))
}
constraints.values.forEach { list ->
list.forEach {
assertEquals(ReferenceOption.CASCADE, it.updateRule)
}
}
}
}
}
}
Loading