Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump detekt version from 1.21.0 to 1.23.1 #1870

Merged
merged 27 commits into from
Sep 26, 2023
Merged

Conversation

joc-a
Copy link
Collaborator

@joc-a joc-a commented Sep 25, 2023

  • Bump detekt version from 1.21.0 to 1.23.1
  • Fix new detekt warnings that show up

After this is merged, please upgrade the detekt plugin in IntelliJ to the latest one (2.1.0 at the time of writing).

Property 'complexity>ComplexMethod' is deprecated. Rule is renamed to `CyclomaticComplexMethod` to distinguish between Cyclomatic Complexity and Cognitive Complexity.
@joc-a joc-a marked this pull request as ready for review September 25, 2023 15:57
@joc-a joc-a requested a review from e5l September 25, 2023 15:57
@joc-a joc-a requested a review from bog-walk September 25, 2023 15:57
@joc-a joc-a merged commit 926c5b1 into main Sep 26, 2023
5 checks passed
@joc-a joc-a deleted the joc/bump-detekt-version branch September 26, 2023 10:37
saral pushed a commit to saral/Exposed that referenced this pull request Oct 3, 2023
* chore: Bump detekt version from 1.21.0 to 1.23.1

* chore: Disable ArgumentListWrapping rule which is active by default since v1.22.0

* chore: Remove SpacingBetweenDeclarationsWithComments rule warnings in exposed-core

* chore: Remove MultiLineIfElse rule warnings in exposed-core

* chore: Add maxLineLength to ParameterListWrapping rule

* chore: Set properties for Wrapping rule

* chore: Disable PropertyWrapping rule which is active by default since v1.23.0

* chore: Disable EnumEntryNameCase rule which is active by default since v1.22.0

* chore: Remove AnnotationOnSeparateLine rule warning in exposed-core

* chore: Remove NoEmptyFirstLineInMethodBlock rule warning in exposed-core

* chore: Remove SpacingBetweenDeclarationsWithAnnotations rule warnings in exposed-core

* chore: Remove SpacingAroundUnaryOperator rule warnings in exposed-core

* chore: Rename ComplexMethod to CyclomaticComplexMethod

Property 'complexity>ComplexMethod' is deprecated. Rule is renamed to `CyclomaticComplexMethod` to distinguish between Cyclomatic Complexity and Cognitive Complexity.

* chore: Remove SpacingBetweenDeclarationsWithAnnotations rule warnings in exposed-crypt

* chore: Remove NoEmptyFirstLineInMethodBlock rule warnings in exposed-crypt

* chore: Remove MultiLineIfElse rule warning in exposed-dao

* chore: Remove FunctionReturnTypeSpacing rule warnings in exposed-dao

* chore: Remove CommentWrapping rule warning in exposed-dao

* chore: Remove SpacingAroundUnaryOperator rule warnings in exposed-dao

* chore: Remove NoSemicolons rule warning in exposed-dao

* chore: Remove SpacingAroundUnaryOperator rule warning in exposed-jdbc

* chore: Suppress Wrapping rule in JodaTimeMiscTableTest.kt

* chore: Remove NoEmptyFirstLineInMethodBlock rule warning in exposed-kotlin-datetime

* chore: Remove SpacingBetweenDeclarationsWithAnnotations rule warnings in exposed-kotlin-datetime

* chore: Remove PackageName rule warnings in exposed-spring-boot-starter

* chore: Remove NoEmptyFirstLineInMethodBlock rule warning in spring-transaction

* chore: Remove AnnotationOnSeparateLine rule warning in spring-transaction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants