deprecate: Raise deprecation level of currentScheme property #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise deprecation level of ExposedDatabaseMetadata.currentScheme from ERROR to WARNING. This property was meant to be private/protected within classes that implement the interface, but has been used in VendorDialect` and 1 unit test. A new abstract fun tableNamesByCurrentSchema() is introduced to abstract away the schema from the core module. Ideally this function would return a List<String> but tableExists() needs to know about the current scheme name, so it instead returns a Pair to provide that.
Change name of private property to no longer have underscore prefix.
bog-walk
commented
Oct 5, 2023
...sed-core/src/main/kotlin/org/jetbrains/exposed/sql/statements/api/ExposedDatabaseMetadata.kt
Outdated
Show resolved
Hide resolved
|
From WARNING to ERROR |
Add data class SchemaMetadata as nre return type of tableNamesBySchema().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise deprecation level of
ExposedDatabaseMetadata.currentSchemefrom WARNING to ERROR.This property was initially deprecated after this PR introduced the possibility to change the schema in runtime.
The goal of this fix is to keep the property private in
JdbcDatabaseMetadataImpl, which has 2 complications:VendorDialectfunctions use it to filter existing table names:tableNamesByCurrentSchema(), which abstracts away the property from the core module. Ideallly this function should only return aList<String>, but it doesn't because of complication 2 (below).VendorDialect.tableExists()uses the property directly, as does 1 unit test:tableNamesByCurrentSchema()instead returns a Pair, which maybe defeats the purpose of making it private.tableExists()intoJdbcDatabaseMetadataImpl. This would require refactoring of the cache inVendorDialectandTable.exists().JdbcDatabaseMetadataImpl.schemaNamescould be refactored to always set the current schema name as the first list element, so it could be reliably found using the cache inVendorDialect. This seems prone to error if any future changes are made.