Improved code of functional logic in Exposed SQL Statement classes

exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/statements/Statement.kt

@@ -115,34 +115,31 @@ class StatementContext(val statement: Statement<*>, val args: Iterable<Pair<ICol
 fun StatementContext.expandArgs(transaction: Transaction): String {
     val sql = sql(transaction)
     val iterator = args.iterator()
+
     if (!iterator.hasNext()) return sql
 
     return buildString {
         val quoteStack = Stack<Char>()
         var lastPos = 0
-        var i = -1
-        while (++i < sql.length) {
+
+        for (i in sql.indices) {
             val char = sql[i]
-            if (char == '?') {
-                if (quoteStack.isEmpty()) {
+            when {
+                char == '?' && quoteStack.isEmpty() -> {
                     if (sql.getOrNull(i + 1) == '?') {
-                        ++i
+                        i.inc()
                         continue
                     }
                     append(sql.substring(lastPos, i))
                     lastPos = i + 1
                     val (col, value) = iterator.next()
                     append(col.valueToString(value))
                 }
-            } else if (char == '\'' || char == '\"') {
-                if (quoteStack.isEmpty()) {
-                    quoteStack.push(char)
-                } else {
-                    val currentQuote = quoteStack.peek()
-                    if (currentQuote == char) {
-                        quoteStack.pop()
-                    } else {
-                        quoteStack.push(char)
+                char == '\'' || char == '\"' -> {
+                    when {
+                        quoteStack.isEmpty() -> quoteStack.push(char)
+                        quoteStack.peek() == char -> quoteStack.pop()
+                        else -> quoteStack.push(char)
                     }
                 }
             }
@@ -154,6 +151,7 @@ fun StatementContext.expandArgs(transaction: Transaction): String {
     }
 }
 
+
 /** Represents the groups that are used to classify the purpose of an SQL statement. */
 enum class StatementGroup {
     /** Data definition language group. */

exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/statements/UpdateStatement.kt

@@ -45,17 +45,21 @@ open class UpdateStatement(val targetsSet: ColumnSet, val limit: Int?, val where
     }
 
     override fun arguments(): Iterable<Iterable<Pair<IColumnType, Any?>>> = QueryBuilder(true).run {
-        if (targetsSet is Join && currentDialect is OracleDialect) {
-            where?.toQueryBuilder(this)
-            values.forEach {
-                registerArgument(it.key, it.value)
+        when {
+            targetsSet is Join && currentDialect is OracleDialect -> {
+                where?.toQueryBuilder(this)
+                values.forEach {
+                    registerArgument(it.key, it.value)
+                }
             }
-        } else {
-            values.forEach {
-                registerArgument(it.key, it.value)
+            else -> {
+                values.forEach {
+                    registerArgument(it.key, it.value)
+                }
+                where?.toQueryBuilder(this)
             }
-            where?.toQueryBuilder(this)
         }
         if (args.isNotEmpty()) listOf(args) else emptyList()
     }
+
 }