fix: Parsing failure when selecting CURRENT_TIMESTAMP using CurrentDateTime function #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teTime function -For H2, the type of the value returned from the database for CurrentDateTime function is OffsetDateTime, which was not being handled correctly in `valueFromDB` function. -For Oracle, the type of the value returned from the database for CurrentDateTime function is oracle.sql.TIMESTAMPTZ, which was not being handled correctly in `valueFromDB` function. The fix for this is to call `rs.getObject(index, java.sql.Timestamp::class.java)` in readObject, which then results in the type being java.sql.Timestamp which is already handled properly in `valueFromDB` function.
joc-a
force-pushed
the
joc/fix-parsing-error-for-current-date-time-function
branch
from
0732664
to
bc8db2c
Compare
e5l
approved these changes
Oct 17, 2023
| fun testCurrentDateTimeFunction() { | ||
| val fakeTestTable = object : IntIdTable("fakeTable") {} | ||
|
|
||
| withTables(fakeTestTable) { |
There was a problem hiding this comment.
Could you log an issue about making API for running such functions? I think it could be helpful for users as well
bog-walk
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valueFromDBfunction.valueFromDBfunction. The fix for this is to callrs.getObject(index, java.sql.Timestamp::class.java)in readObject, which then results in the type being java.sql.Timestamp which is already handled properly invalueFromDBfunction.