feat: EXPOSED-224 Add query timeout at Transaction #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FullOfOrange
commented
Nov 22, 2023
exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/statements/Statement.kt
Outdated
Show resolved
Hide resolved
FullOfOrange
changed the title
FullOfOrange
changed the title
bog-walk
requested changes
Nov 23, 2023
exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/Transaction.kt
Outdated
Show resolved
Hide resolved
exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/statements/Statement.kt
Outdated
Show resolved
Hide resolved
exposed-tests/src/test/kotlin/org/jetbrains/exposed/sql/tests/shared/QueryTimeoutTest.kt
Outdated
Show resolved
Hide resolved
exposed-tests/src/test/kotlin/org/jetbrains/exposed/sql/tests/shared/QueryTimeoutTest.kt
Outdated
Show resolved
Hide resolved
bog-walk
changed the title
bog-walk
approved these changes
Nov 24, 2023
e5l
approved these changes
Nov 24, 2023
|
Spring transaction timeout support at #1897 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue #1671
This is a PR to support timeout in Transaction.
I simply added a timeout to the PreparedStatement so that it can use the DB driver's timeout.
For now, I only want to use timeout in transactions, so I kept the implementation as simple as possible. This could be extended in the future to use timeout wherever it is needed.