fix: EXPOSED-226 Upsert fails with only key columns in update #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If all columns in an upsert block are conflict/key columns and onUpdate is not set, an empty update clause is generated, which throws an SQLException in all databases except MySQL and MariaDB. Including these key columns in the update clause is valid SQL in all databases except Oracle, so filtering the update columns now only happens if the result will not be an empty list.
bog-walk
changed the title
Edit test to include Oracle.
e5l
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all columns in an
upsert()block are conflict/key columns, andonUpdateis not set, an empty update clause is generated, which throws an SQLException in all databases except MySQL and MariaDB.It is important to allow key columns in the update clause for databases that do not support
insertIgnore()and must use upsert to achieve this functionality.Including these key columns is valid SQL in all databases except Oracle, which throws
ORA-38104: Columns referenced in the ON Clause cannot be updated.So filtering the update columns now only happens if the result will not be an empty list.