docs: Add MIGRATION_GUIDE #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bog-walk
commented
Dec 7, 2023
Comment on lines
+92
to
+94
| val originalQuery = TestTable.selectAll().where { TestTable.columnA eq 1 } | ||
| originalQuery.adjustSelect { select(TestTable.columnA) } | ||
| ``` |
There was a problem hiding this comment.
This section will need to be edited (and an extra step included below) if #1934 is not accepted.
e5l
approved these changes
Dec 7, 2023
|
@e5l Should anything be done about this old guide in the Wiki? |
|
@bog-walk, let's drop it |
joc-a
approved these changes
Dec 8, 2023
Duplicate migration guide to writerside docs as well
Minor edits and remove any mention of adjustSelect set property.
bog-walk
force-pushed
the
bog-walk/add-migration-guide
branch
from
19e9651
to
cbd4b5e
Compare
Update README to reflect new DSL changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2 docs are duplicates for now, but, in the future, the library doc could just hold a link to the live writerside page, like what's done in Ktor.
Includes new DSL changes in README.