fix: EXPOSED-244 [PostgreSQL] Collate option on column not recognized #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike all other dialects, PostgreSQL column COLLATE clause requires that the option is quoted as part of the column definition.
bog-walk
commented
Jan 2, 2024
Comment on lines
547
to
+553
| protected fun escape(value: String): String = value.map { charactersToEscape[it] ?: it }.joinToString("") | ||
|
|
||
| /** Returns the specified [value] with special characters escaped and wrapped in quotations, if necessary. */ | ||
| protected fun escapeAndQuote(value: String): String = when (currentDialect) { | ||
| is PostgreSQLDialect -> "\"${escape(value)}\"" | ||
| else -> escape(value) | ||
| } |
There was a problem hiding this comment.
This logic could not be applied directly to escape() because nonNullValueToString() is dependent on it.
The quotation is only necessary in sqlType() overrides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike all other dialects, PostgreSQL column COLLATE clause requires that the option is quoted as part of the column definition.