Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EXPOSED-252 Json contains() throws with iterable as argument #1963

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

bog-walk
Copy link
Member

@bog-walk bog-walk commented Jan 9, 2024

If a json column is declared as storing a list/set/array of values and one of these iterables is used with the function contains(), a syntax error exception is thrown.

The function now properly wraps the serialized json list with quotes when the SQL is generated.

If a json column is declared as storing a list/set/array of values and one of
these iterables is used with the function contains(), a syntax error exception
is thrown.

The function now properly wraps the serialized json list with quotes when the
SQL is generated.
@bog-walk bog-walk requested a review from e5l January 9, 2024 02:27
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bog-walk, thank you for the PR!

LGTM

@bog-walk bog-walk merged commit 412a98f into main Jan 9, 2024
5 checks passed
@bog-walk bog-walk deleted the bog-walk/fix-json-contains branch January 9, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants