fix: EXPOSED-257 Upsert incorrectly parameterizes non-literal WHERE arguments #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guments Currently when using upsert() with a where argument, only literal values generate valid SQL. Attempting to use a value with a param() wrapper or the plain native type results in an exception that the parameter count is incorrect. This occurs because the where arguments were not correctly added to the list of statement arguments in the super class, so an override has now been included in UpsertStatement directly.
…rguments Remove unused import
e5l
approved these changes
Jan 12, 2024
exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/statements/UpsertStatement.kt
Outdated
Show resolved
Hide resolved
joc-a
approved these changes
Jan 12, 2024
…rguments Replace the not-null assertion operator in sub and super classes with Elvis operator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using
upsert()with awhereargument, only column expressions and literal values are being handled correctly in thePreparedStatementSQL.Attempting to use a value that should be parameterized (by using
param()functions or primitive types) results in an exception stating that the provided parameter count is incorrect.This occurs because the
wherearguments are not correctly added to the list of statement arguments in the super classInsertStatement.An
arguments()override that includes thesewherearguments has now been added to theUpsertStatementclass.