fix: EXPOSED-261 [H2] JSON column throws when setting nullable parameters #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters When using H2, attempting to insert a null value into a nullable JSON column results in an NPE that states: 'null cannot be cast to non-null type kotlin.String'. When using PostgreSQL-NG, attempting to retrieve a null value stored in a JSON column results in a deserialization error because non-null object is read with string value 'null'. Both these issues occur because the JsonColumnType override for setParameter() does not handle null values correctly. In the case of PostgreSQL-NG, this meant that a null value was being stored as a string literal instead of SQL NULL. If null values are passed, the dialect overrides now pass them on to the super implementation so they can be handled correctly.
joc-a
approved these changes
Jan 16, 2024
e5l
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using H2, attempting to insert
nullinto a nullable JSON column results in an NPE that states:When using PostgreSQL-NG, attempting to retrieve a null value stored in a JSON column results in a deserialization error because a non-null object is read with string value
'null'.Both these issues occur because the
JsonColumnTypeoverride forsetParameter()does not handle null values correctly.In the case of PostgreSQL-NG, this meant that a null value was being stored as a string literal instead of SQL NULL.
If null values are passed, the dialect overrides now ensure that they are sent to the super implementation so they can be handled as SQL NULL.