fix: EXPOSED-272 [MySQL, Oracle] Unsupported type BIGINT UNSIGNED for auto-increment #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… auto-increment With both Oracle and MySQL, attempting to create a table with an unsigned integer or long column that should auto-increment throws an `Unsupported type` exception. This occurs because `AutoIncColumnType`, which delegates to the underlying type, is currently set up to only detect signed integer and long column types. It is not possible to reuse the existing `integerAutoincType()` or `longAutoincType()` if the delegate is an unsigned column because of the type syntax differences between standard and auto-incrementing columns in some database. So new types have been added to `DataTypeProvider`.
… auto-increment Move drop function in test.
joc-a
approved these changes
Feb 2, 2024
e5l
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With both Oracle and MySQL, attempting to create a table with an unsigned integer or long column that should auto-increment throws an
Unsupported typeexception.This occurs because
AutoIncColumnType, which delegates to the underlying type, is currently set up to only detect signed integer and long column types.It is not possible to reuse the existing
integerAutoincType()orlongAutoincType()if the delegate is an unsigned column because of the type syntax differences between standard and auto-incrementing columns in some databases. So new types have been added toDataTypeProvider.