fix: EXPOSED-287 Wrong parenthesis with advanced use of isDistinctFrom #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to use either operator isDistinctFrom() or isNotDistinctFrom() with a left-or right-side value that is a complex expression results in either a syntax exception or incorrect results (depending on the database). Complex expressions like isNull() and isNotNull() are already marked, so this fix ensures that they are identified as such and wrapped in parentheses when appending to a query builder, by using appendExpression() instead of base append().
e5l
approved these changes
Feb 13, 2024
joc-a
approved these changes
Feb 13, 2024
| @@ -29,7 +29,7 @@ class ConditionsTests : DatabaseTestsBase() { | |||
| val number2 = integer("number_2").nullable() | |||
| } | |||
| // remove SQL Server exclusion once test container supports SQL Server 2022 | |||
There was a problem hiding this comment.
Should we create a YouTrack issue for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to use either operator
isDistinctFrom()orisNotDistinctFrom()with a left- or right-side value that is a complex expression results in either a syntax exception or incorrect results (depending on the db):isNull()andisNotNull()are already marked asComplexExpression.This fix ensures that any such expressions are identified properly when appending to the query builder, by using
appendExpression()instead of baseappend().