Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add ArrayColumnType default override for datetime module types #1995

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

bog-walk
Copy link
Member

  1. Add column type override so default datetime lists are not treated as text type.
  2. Add unit tests in the 3 datetime modules.

}

withTables(excludeSettings = TestDB.entries - TestDB.POSTGRESQL - TestDB.H2, tester) {
addLogger(StdOutSqlLogger)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed when I rebase after merging the older array PR.

@bog-walk bog-walk requested review from e5l and joc-a February 14, 2024 21:34
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, lgtm

Add column type override so default lists are not treated as text type.

Add unit tests in the 3 datetime modules.
@bog-walk bog-walk force-pushed the bog-walk/add-array-datetime-tests branch from e48971a to fe0ebd4 Compare February 20, 2024 18:04
@bog-walk bog-walk merged commit b29cf41 into main Feb 20, 2024
5 checks passed
@bog-walk bog-walk deleted the bog-walk/add-array-datetime-tests branch February 20, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants