fix: EXPOSED-293 Logger prints plaintext value of encryptedVarchar #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using either encryptedVarchar() or encryptedBinary() columns with an enabled logger, the logger output includes the actual unencrypted string values for the statement parameters. This occurs because both columns delegate to super.nonNullValueToString() which just processes the provided string value without encryption.
bog-walk
commented
Feb 26, 2024
Comment on lines
+16
to
+19
| <logger name="Exposed" level="INFO" additivity="false"> | ||
| <appender-ref ref="ASYNC"/> | ||
| </logger> | ||
| </configuration> |
There was a problem hiding this comment.
This file has been added to the test directory to set default log level to INFO. Otherwise, creating a LogCaptor in any unit test spams the console with debug logs from all tests in suite.
e5l
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using either
encryptedVarchar()orencryptedBinary()columns with an enabled logger, the logger output reveals the actual unencrypted string values for the statement parameters, rather than the encrypted value sent to the database.This occurs because both columns delegate to the default
super.nonNullValueToString()which just processes the provided input values without encryption.