Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: EXPOSED-340 Syntax error using upsert with MySQL8 below 8.0.19 #2049

Merged
merged 2 commits into from
Apr 17, 2024
Merged

fix: EXPOSED-340 Syntax error using upsert with MySQL8 below 8.0.19 #2049

merged 2 commits into from
Apr 17, 2024

Commits on Apr 16, 2024

  1. fix: EXPOSED-340 Syntax error using upsert with MySQL8 below 8.0.19 

    MySQL `upsert()` uses an alias for the insert row values when the database
version is 8+.
Technically this is only possible starting with version 8.0.19.

Existing function `MysqlDialect.isMysql8` calls `isVersionCovers()`, which only
fetches the database's major and minor version, so it is not sufficient for
this comparison.
To get the patch version as well requires fetching metadata using the full
`databaseProductVersion` property.
    @bog-walk
    bog-walk committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    4808971 View commit details
    Browse the repository at this point in the history

  2. fix: EXPOSED-340 Syntax error using upsert with MySQL8 below 8.0.19 

    Change implementation to use a lazy property so metadata isn't fetched on
every upsert call.
    @bog-walk
    bog-walk committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    3377104 View commit details
    Browse the repository at this point in the history