Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: EXPOSED-360 Storing ULong.MAX_VALUE in ulong column not working #2068

Merged
merged 1 commit into from
May 30, 2024
Merged

fix!: EXPOSED-360 Storing ULong.MAX_VALUE in ulong column not working #2068

merged 1 commit into from
May 30, 2024

Commits on May 30, 2024

  1. fix!: EXPOSED-360 Storing ULong.MAX_VALUE in ulong column not working 

    Before this fix, the maximum value that could be stored with `ULongColumnType` for all database dialects was `Long.MAX_VALUE`. This is because the `ULong` value was being converted to `Long` in the `notNullValueToDB` function, restricting the range to that of `Long`. Instead, it is now converted to a `Long` only for PostgreSQL, and a `String` for the rest of the database dialects. For PostgreSQL, it is not possible to store a value greater than `Long.MAX_VALUE` at the moment. This is because it's not possible to have an auto-increment column of the same type NUMERIC(20), and having different types for `ulongType()` and `ulongAutoincType()` will cause a crash when one references the other. This will be solved in another pull request.

Breaking change: `ulongType()` is now NUMERIC(20) instead of BIGINT for H2, SQL Server, and SQLite, to allow storing the full range of `ULong`.
    @joc-a
    joc-a committed May 30, 2024
    Configuration menu
    Copy the full SHA
    10a200a View commit details
    Browse the repository at this point in the history