EXPOSED-409 Custom primary key. Access to the primary key fails with …

[obabichevjb]

Fixes the problem of accessing column with custom entity id.

Before the fix two sequential accesses like entry[tester.value] and entry[tester.id].value to the column cause class cast exception due to caching by the column.

After the fix the column value would be cached twice by different keys. Before the fix the expression that used for data access was taken as a key of caching. After the fix the key was extended with the column type, because two "equal" (in terms of Object::equal()) expressions (actually columns) may have a different column type and must return different values (value and entity id of that value).

[bog-walk]

I'm wondering if this could be solved by adjusting the equality check directly. For example, using the original ResultRow cache, just removing this line in EntityIdColumnType.equals() makes the test pass.

I introduced that line (and therefore also this issue) to resolve an issue with primary key generation for these exact types of custom id tables. In PR #1728
Maybe you can see a better solution for that original issue that would avoid adding this line (and therefore make this current issue go away)?

[bog-walk]

Please move this to a more appropriate test file. Anything in shared/entities I guess.

Also, is there a reason junit.framework.TestCase.assertEquals is being used instead of regular assertEquals()?

[obabichevjb]

Haven't found a better place than EntityBugsRegressionTest...