feat!: EXPOSED-476 Update Kotlin to 2.0.0 #2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bog-walk
commented
Aug 5, 2024
| object ForUpdate : ForUpdateOption("FOR UPDATE") | ||
| data object ForUpdate : ForUpdateOption("FOR UPDATE") |
There was a problem hiding this comment.
@e5l Changes in this file are based on suggestion that 'Sealed sub-object can be converted to data object'. Given that it is an API change, would it be better to not include it in this PR? Or should I add it as a small note to the breaking change docs?
e5l
approved these changes
Aug 5, 2024
bog-walk
force-pushed
the
bog-walk/kotlin-2.0.0
branch
from
30f77ba
to
be44c3f
Compare
bog-walk
changed the title
Bump Kotlin version to 2.0.0 (as well as kotlinx.serialization plugin) Fix compiler error for: - Type argument can't be inferred with eq Fix all compiler warnings for: - KDocs: Cannot resolve symbol - Unused suppressions - Redundant 'if' statements - Remove explicit type arguments - 'Sealed' sub-object can be converted to 'data object' - Value of 'value' is always null - Deprecated: 'kotlinOptions' nd 'newInstance()' - Unused parameters - Implicit parameter shadowed
Add line to Breaking change docs regarding conversion from object to data object.
bog-walk
force-pushed
the
bog-walk/kotlin-2.0.0
branch
from
be44c3f
to
839b948
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change: Bump Kotlin version to 2.0.0 in all places (as well as kotlinx.serialization plugin)
Detailed description:
getting-startedsnippet have been confirmed to run as expectedeq'ifstatementsSealedsub-object can be converted todata objectkotlinOptionsandnewInstance()Type of Change
Please mark the relevant options with an "X":
Affected databases:
Checklist
Related Issues
EXPOSED-476