fix: EXPOSED-467 Decimal type precision and scale not checked by SchemaUtils #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…maUtils Any difference column type that includes a user-defined column size (precision) or scale in the SQL type is not detected as a ColumnDiff when SchemaUtils functions are used. Column metadata for the fractional digits (scale) is now also read and use with the existing column size to determine if an alter statement should be generated.
bog-walk
force-pushed
the
bog-walk/fix-schema-utils-column-type
branch
from
75ac5c6
to
37f2cca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change:
Defining the same column of type
decimal(),binary(),varchar(), orchar()but with a different size (precision) or scale (fordecimalonly) now correctly triggers an ALTER statement whenSchemaUtils.createMissingTablesAndColumnsis used.Detailed description:
Why:
Currently, if the existing database table has a column of type DECIMAL(?,?), VARCHAR(?), VARBINARY(?), or CHAR(?) and the Exposed table object defines the same column type but with a different size, the
SchemaUtilsfunctions will not generate any ALTER statements to fix the inconsistency.What:
SchemaUtils.createMissingTablesAndColumnsnow compares existing- and defined- column size (and scale, if applicable to type) when inspecting theColumnDiff.How:
DECIMAL_DIGITSlabel for scale (only non-null for decimal types).COLUMN_SIZEis now used as part of theColumnDiffcomparisonType of Change
Please mark the relevant options with an "X":
Updates/remove existing public API methods:
Affected databases:
Checklist
Related Issues
EXPOSED-467