EXPOSED-203 Lightweight DAO insert with encryptedVarchar attemtps to … #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…decrypt unencrypted input
obabichevjb
force-pushed
the
obabichev/exposed-203-decrypt-unencrypted-values
branch
from
f2a94a4
to
2834603
Compare
bog-walk
approved these changes
Aug 9, 2024
exposed-crypt/src/test/kotlin/org/jetbrains/exposed/crypt/EncryptedColumnDaoTests.kt
Outdated
Show resolved
Hide resolved
obabichevjb
deleted the
obabichev/exposed-203-decrypt-unencrypted-values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's the issue similar to EXPOSED-474 Unexpected value of type when using a ColumnTransformer in a DAO object
The problem is that due to internal implementation of
ResultRow, it tries to callvalueFromDbmultiple times. As a result, after the first call value is decrypted, and on the second call (with already decrypted value) it fails.This behavior was already fixed for transformed columns, so it looks reasonable to reuse the new concept here too. So I updated
EncryptedBinaryColumnTypeandEncryptedVarCharColumnTypeto useColumnWithTransformunder the hood. It also makes code simpler because there is no overriding ofIColumnTypeinterface methods.Detailed description:
Type of Change
Please mark the relevant options with an "X":
Affected databases:
Related Issues
EXPOSED-203 Lightweight DAO insert with encryptedVarchar attemtps to decrypt unencrypted input