fix: EXPOSED-509 Upsert with escaped multiline string fails in prepared statement #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed stateme> The update clause of an upsert statement is being prepared without appropriate parameterisation, leading to any multiline strings being treated as string lite> and escaped, thereby losing any indentation. This occurs because the appropriate registerArgument() invokations are not being used, particularly for databases that use merge syntax.
…ed statement - Remove accidentally left in println()
…ed statement - Add test that covers onUpdate with set array - Switch new test (passes even with fix) to actual db integration test that would fail without StatementContext.expandArgs() fix
bog-walk
force-pushed
the
bog-walk/fix-multiline-string-upsert
branch
from
efc3218
to
015c0d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change:
Statement prepared by
upsert()now properly registers parameter arguments in the UPDATE clause.Detailed description:
Expression arguments in the UPDATE clause were being treated as statement literals. So multiline strings, for example, were being escaped and losing any indentation/formatting when sent to and from the database.
Expression arguments are now properly registered during SQL string building. Databases that rely on the MERGE statement for upsert require special treatment because all expressions must be aliased, which is problematic because the expression should be registered but only with its column identifiers replaced by a dynamic alias.
Type of Change
Please mark the relevant options with an "X":
Affected databases:
Checklist
Related Issues
EXPOSED-509