fix: EXPOSED-551 [SQL Server] Update from join with limit throws syntax exception #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obabichevjb
approved these changes
Sep 19, 2024
…ax exception Attempting to perform an update from a join, with a provided limit, throws a syntax exception if either SQL Server or MySQL is used. The former because of an error in generated SQL and the latter because it is not allowed (when it should fail early).
…ax exception - Rebase from main - Clean up tests to use local properties
bog-walk
force-pushed
the
bog-walk/fix-join-update-limit
branch
from
8de51ad
to
327a742
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change:
Join.update(limit = ?)now uses correct syntax with SQL Server and fails early for MySQL. These were not caught because there was no test for this operation.Detailed description:
Attempting to perform an update from a join, with a provided limit, throws a syntax exception for SQL Server:
because generated SQL uses both
TOPandLIMITclauses, when onlyTOPsyntax should be used.An exception is also thrown for MySQL:
because
LIMITclause is being added even though the database does not support it for multiple-table syntax. Attempting to do so with this database should instead cause an early failure.TOPsyntax alone iflimitis not null.UnsupportedByDialectExceptioniflimitis not null.Type of Change
Please mark the relevant options with an "X":
Affected databases:
Checklist
Related Issues
EXPOSED-551