feat: EXPOSED-555 Allow read-only suspendable transactions #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RenanKummer
changed the title
RenanKummer
changed the title
bog-walk
requested changes
Nov 26, 2024
There was a problem hiding this comment.
Thanks for working on this feature request @RenanKummer
Please consider rebasing from main and addressing changes below.
This PR has been labelled feat! but the BreakingChanges docs has not been updated. Given the default argument, the likeliness of using a statement lambda, and our versioning, it would be fine to label feat.
But if you're concerned about non-named arguments in the parameter list and wish to keep this label for thoroughness, then please also add a note under section 0.57.0 of the BreakingChanges doc.
exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/transactions/experimental/Suspended.kt
Outdated
Show resolved
Hide resolved
exposed-tests/src/test/kotlin/org/jetbrains/exposed/sql/tests/postgresql/ConnectionPoolTests.kt
Outdated
Show resolved
Hide resolved
Regular transaction management allow callers to configure if new transactions should be read-only. This change adds the same behavior to suspendable transactions.
RenanKummer
changed the title
|
@bog-walk - Could you please review again? I applied the suggested changes. |
bog-walk
approved these changes
Nov 26, 2024
e5l
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change: Regular transaction management allow callers to configure if new transactions should be read-only. This change adds the same behavior to suspendable transactions.
Detailed description:
readOnlyparameter has been added fornewSuspendTransaction.readOnlyto be configured by callers. As per JetBrains Exposed documentation, this behavior is supposed to be the same for regular and suspendable transactions, but the parameter was missing for suspendable transactions.null) to avoid breaking changes as much as possible. It is passed ahead to internal functions in order to create the transaction either as read-only based on caller's configuration or as the original behavior for existing code.Type of Change
Please mark the relevant options with an "X":
Updates/remove existing public API methods:
Affected databases:
Checklist
Related Issues
https://youtrack.jetbrains.com/issue/EXPOSED-555/newSuspendedTransaction-support-for-readOnly
EXPOSED-243