fix: Make using Java's ServiceLoader optional on Database.connect() #2293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change: Make using ServiceLoader for DatabaseConnectionAutoRegistrationnot optional
Detailed description:
connectionInstanceImpl
doesn't need to be created using javaServiceLoader
.connectionInstanceImpl
is now lazy-loaded so even ifServiceLoader
doesn't have required service, code block will not crash. Everyconnect
method have nowconnectionAutoRegistration
as a parameter instead of previous private-service-loadedType of Change
Please mark the relevant options with an "X":
Updates/remove existing public API methods:
Affected databases:
Checklist
Related Issues