-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacing only ligatures variant #11
Comments
Really nice font. I agree. I'd love a version that only includes whitespace-shifting ligatures.
Instead of joining |
This is why I can't use ligatures the way they are now. As for implementation, there is one more option to consider. Fira Code ships with stylistic sets, and some IDEs (such as VScode) can use them to adjust the looks of certain symbols. The comment #19 (comment) makes a good summary about issues with ligatures. |
@KillyMXI The bugs @cipriancraciun referring to are mainly closed. |
@philippnurullin My takeaway from that comment is that if you take too much liberty with symbols interpretation, there inevitably will be cases when your interpretation conflicts with various contexts. In my opinion, ideal font will have alignment-only ligatures by default and have language-specific toggles. And still, I can't stand your interpretation of |
@KillyMXI Actually we have some experiments running in this field, but can't say more. So the temporary solution will be version without ligatures, which will be present in next update. |
@KillyMXI You may disagree, but I actually quite like the ligature for |
Ok to be fair I think your second design is actually better, mainly cause
of the preservation of character order.
…On Sat, 18 Jul 2020, 23:36 MXI, ***@***.***> wrote:
I can't disagree *you* like it.
Even if I were less concerned about the disconnection between the shape
and underlying characters, this symbol still has another issue:
Thin diagonal line is actually hard to see. It always demands for a second
look to make sure it is not ===.
Reading code like this is like walking a mine field. I don't understand
why anyone would trade legibility for slick look.
I would've made it something like this:
[image: image]
<https://user-images.githubusercontent.com/13851064/87862877-74fb7700-c95d-11ea-93c9-6c2ed6978129.png>
(Thick diagonal to make sure it doesn't get lost in any font size on any
monitor, thin breaks to make it stand out even more.)
Then, in order to keep it closer to the underlying characters order, I
would move it to the left:
[image: image]
<https://user-images.githubusercontent.com/13851064/87862984-d53ee880-c95e-11ea-9432-3e79fc544efe.png>
Then I would try to replace / with ! and we are close to spacing only
ligature...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AETAXXXGDXYPIXCNMWV25BLR4IPWFANCNFSM4KHHLX4A>
.
|
I think there are 2 requests in this issue:
How do you feel about opening a second issue for this second request to keep track of it? |
@philippnurullin additionaly, what about adding the "stylistic sets suggestion" label to this issue |
@CircleCode You are right this is two separate requests. You can create the issue with request for stylistic set with alternate construction for ligatures. Please add examples if you have them. |
@philippnurullin to be sure I correctly understand,
what you are investigating is to be able to enable ligatures sets, like for example
you ask for examples of differences I'd like to see for stylistic ligatures, right? |
Yes, and java only spacing ligatures too.
Yes. More minds almost every time better that one. ) |
@philippnurullin #287 opened |
@philippnurullin Do you mean there won't be any way to only enable the spacing only ligatures? That's pretty sad, but in that case, this issue should be closed, shouldn't it? I really hope that's not the case though. Any insight to why that decision was made? |
@CreamyCookie Sorry for the wait.
Yes, there will be. But it won't be a different font file.
I can close the issue, but i'd like to keep it open until we release the solution. |
Great to hear! =) |
Interesting case of a font with safe-ish ligatures only: https://github.com/0xType/0xProto In practice, it seems they still took too much liberty when moved symbols closer together in ligatures. Previously, I made a comment that is related to this issue: #287 (comment) Now it seems that designing those with monospace grid awareness is also necessary, in order to avoid creating empty space. |
This font looks really nice, but I don't want the symbol ligatures - I find they make things harder to understand. Is there any chance of releasing a version with these ligatures removed?
I've seen some fonts include a configurator that allows you to download different font variants (See: Input). Perhaps something like that might work out?
The text was updated successfully, but these errors were encountered: