Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Powerline font is taller than line height in v1.0.4 #172

Closed
msjohal opened this issue Mar 11, 2020 · 9 comments
Closed

Powerline font is taller than line height in v1.0.4 #172

msjohal opened this issue Mar 11, 2020 · 9 comments
Labels
bug Something isn't working

Comments

@msjohal
Copy link

msjohal commented Mar 11, 2020 •
edited
Loading

Powerline separator height taller than the line height, in v1.0.3 the height was correct. This was in alacritty on MacOS
Screen Shot 2020-03-11 at 10 49 22 AM
@philippnurullin
Copy link
Member

@msjohal Yes, the height of arrow elements was increased to match Box Drawing. What IDE you using?

@philippnurullin philippnurullin added the bug Something isn't working label Mar 12, 2020
@msjohal
Copy link
Author

msjohal commented Mar 12, 2020

That was in neovim

@delphinus
Copy link

I think it depends on the terminal you use. @msjohal I see them with the valid size in my env (iTerm2).

@msjohal
Copy link
Author

msjohal commented Mar 16, 2020 •
edited
Loading

I still see the issue in iTerm2, it's only slightly larger, but it's still larger. Both screenshots are with font size 13.
Screen Shot 2020-03-15 at 5 08 36 PM

@delphinus
Copy link

I see. I found it depends on some settings in iTerm2.

スクリーンショット 0002-03-16 19 19 12

When you disable this option (choose: Never), you can see the triangle sticking out.

スクリーンショット 0002-03-16 19 33 53

When enabled, it almost disappears, but I can see 1x2 dots.

スクリーンショット 0002-03-16 19 33 22

FYI: iTerm2 has built-in Powerline glyphs in it. So you can see perfect triangles with using the option: Use built-in Powerline glyphs.

スクリーンショット 0002-03-16 19 34 17

@philippnurullin
Copy link
Member

Fix will be in v1.0.5

philippnurullin added a commit that referenced this issue Mar 26, 2020
@philippnurullin
v1.0.5
26e6526 
— Lowered the height of Powerline arrows #172
— <*> Interpolation bug fix #180
— Removed ligatures from loading sequences [-> [=> #151
— Tuned 1 to be more distinguishable from i in small sizes #176
— Sorted glyphs by unicode order #170
— Added U+02BC "Modifier Letter Apostrophe" #168
— Added new ligature @_
— Added 29 glyphs: ƏəǦǧǪǫǴǵ∀∃∈∋∐⟨⟩∧∨∷∼≈≡⍴­■▲▶▼◀◆●
— Added support of https://unicodepowersymbol.com/
— Refactored ¶ l j
@philippnurullin
Copy link
Member

Feel free to reopen if you you experiencing some bugs with new release.

@felixse
Copy link

felixse commented Mar 26, 2020

image

Arrows are not rendered (just a thin line if you look closely) in vscode and Fluent Terminal (both based on xterm.js) since the 1.0.5 update. No problems in Windows Terminal though

@philippnurullin
Copy link
Member

@felixse Sorry for the stupid questions. Did you removed the old version of the font first? If not please remove it first, after reinstall the latest update & restart, to be sure.
If problem is still present please create a new issue, or drop me a line & i will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@delphinus @msjohal @felixse @philippnurullin