Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support U+0336 COMBINING LONG STROKE OVERLAY #190

Closed
trygveaa opened this issue Mar 30, 2020 · 1 comment
Closed

Support U+0336 COMBINING LONG STROKE OVERLAY #190

trygveaa opened this issue Mar 30, 2020 · 1 comment
Labels
unicode request Request for adding more symbols

Comments

@trygveaa
Copy link

It would be nice if the overlay character to strike out a character were supported. This is useful for printing striked out text.

Preferably it should look the same as when the font is drawn with the strikeout position and size already specified in the font.

The need for this is that although many terminal emulators support the CSI sequence for strikethrough, ncurses and terminfo don't support it as far as I know, so there are many applications that can't use it.
@philippnurullin philippnurullin added the unicode request Request for adding more symbols label Apr 1, 2020
philippnurullin added a commit that referenced this issue Apr 8, 2020
@philippnurullin
v1.0.6
5753521 
— Fixed problem with disappeared Powerline arrows #189
— Added U+0336 #190
— Added >-> Ligature #194
— Fixed rendering problems with arrow in ligatures #196
— Added exclusion in ligatures with -- --- to treat loading #151
— Added source files in .ufo format
philippnurullin added a commit that referenced this issue Apr 29, 2020
@philippnurullin
v1.0.6
4dd35ad 
Major changes
— Fixed problems with rendering of Powerline symbols #189
— Added support of Vietnamese language #14 #209
— All diacritics redone. Corrected a bunch of problems of placing & more balanced mass.
— Added DesignSpace+UFO source files. Just converted & dumped as they are, for now. There are issues with Masters compatibility. Tested in Glyphs app.

Other fixes
— Fixed construction of † ‡ ∏ ∐  #205 #206
— Added exclusion in /* ligature #88
— Refactored ß
— ~= ligature removed #204
— Added >-> ligature #194
— Added u0336 Long stroke overlay #190
— Added ligature //= #185
— Corrected contour of the arrows in ligatures #196

Known issues
— In Medium weights the height of [ ] { } decreased by one pixel in 12px, 13px sizes. This is a hinting bug.
@trygveaa
Copy link
Author

Thanks for adding this!

One minor issue is that there seems to be some very minor gaps between the strikes, which can be seen with large font sizes:
jetbrains-mono-overlay-character

This is with kitty. Is this something that can be fixed? Does the line go to the end of the character on both sides?

I also see that the position and width differs slightly from when you draw a strikethrough using the strikethrough position and width specified in the font instead of using the overlay character:

jetbrains-mono-native-strikethrough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unicode request Request for adding more symbols
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trygveaa @philippnurullin