Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*ML comment ligatures are vertically misaligned #77

Closed
zbee opened this issue Jan 21, 2020 · 2 comments
Closed

*ML comment ligatures are vertically misaligned #77

zbee opened this issue Jan 21, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@zbee
Copy link

zbee commented Jan 21, 2020

XML/HTML comment opening and closing ligatures are vertically misaligned, with the opening ligatures (<!--) being one pixel above the closing ligature (-->).

Please see the image below, red line added for clarity.
image
@philippnurullin philippnurullin added the bug Something isn't working label Jan 22, 2020
@cipriancraciun cipriancraciun mentioned this issue Feb 5, 2020
Closed
philippnurullin added a commit that referenced this issue Mar 11, 2020
@philippnurullin
v1.0.4
c7d5193 
— Added No Ligature version. Only in `.ttf` format. It called **JetBrains Mono NL**. #19
— Fixed problems with tiny gaps between the Box Drawing elements. #84
— Balanced the size of `<>` `</>` ligatures to match in mass. #116
— Fixed problem with not working `<--` ligature. #95
— Added `U+FEFF` symbol. No-break zero space. #147
— `<!--` `-->` ligatures now should be on the same heights. #77
— Corrected `===>` behaviour in loading sequences. #151
— Corrected `A` placement in italics.
— Made dot in the `0` smaller, so it will be more distinguishable from `8` at small sizes.
@philippnurullin
Copy link
Member

@zbee Hi, i made some adjustments in v1.0.4. Do you still experience this problem?

@zbee
Copy link
Author

zbee commented Apr 4, 2020

@philippnurullin Apologies, I did not see this before now. I will try to test this the day after tomorrow.

I do not, however, have access to that exact environment (my work machine, which is in a locked and closed office), so not seeing the issue may not be exemplary of the issue being resolved. Just a note.

philippnurullin added a commit that referenced this issue Jul 10, 2020
@philippnurullin
Updated to v2.000
598943b 
— Added 3 lighter weights with matching italics #1
SemiLight — Special for the dark background. It’s a slightly more thin version of Regular.
Light — Will perform best on HiDpi in more big sizes.
ExtraLight — If you want to go even thinner. Recommended for presentation mode.
— Added Variable format for more precise weight tuning.
— Project migrated from FontLab to Glyphs. Source in UFO provided.
— *ML comment ligatures are vertically misaligned #77
— Ligatures in a glob pattern look inconsistent #88
— Zero - hinting the dot #104
— Big space above text in OneNote #210
— Corrected hinting #218 #235 #239 #252
— Monospaced detection errors  #227 #230
— Wrong interpretation in "<||> |>" #234
— Reworked % ‰ #236
— Missing some Powerline symbols #240
— Disable `>-` ligature when followed by `<` (`>-<`) #251
— Add the Latin Capital Letter Sharp S (U+1E9E) #262
— Added superior & inferior numbers ⁰¹²³⁴⁵⁶⁷⁸⁹₀₁₂₃₄₅₆₇₈₉
— Fine tuning of capital, ascender & descender metrics
— Raised the bar in `f` to work better in context of the line
— More spacing tuning in arrow ligatures
— Corrections in  -<  -<<  <— <!—
— More pronounced bar in Ħ Ŧ ћ ħ đ ŧ
— Correct u+02C9 placement
— Corrected placement of Ogonek in Uogonek
— Corrections in Vietnamese diacritics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zbee @philippnurullin