Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBR API v0.0.8 - add GraphicsUtils #208

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Conversation

AMPivovarov
Copy link
Contributor

@AMPivovarov AMPivovarov commented Jan 25, 2023

@JB-Dmitry
Copy link
Contributor

I'd propose to change the constraint-related methods in ConstrainableGraphics2 to be:

Rectangle2D getConstrainingRegion();
void constrain(Rectangle2D region);

This allows to get the dimensions of the constraining region, for symmetry, along with its location. And using floating-point coordinates will allow to add support for HiDPI cases in future, if needed, without extending the interface.

@JB-Dmitry
Copy link
Contributor

Actually, using floating point coordinates only makes sense if coordinates are given in user space. sun.awt.ConstrainableGraphics's javadoc speaks about device space coordinates - for them integer coordinates should be fine.

@YaaZ YaaZ merged commit 8b1c8f8 into JetBrains:main Jan 30, 2023
vprovodin pushed a commit that referenced this pull request Jan 31, 2023
* relax type constraints in BltBufferStrategy.getDrawGraphics
vprovodin pushed a commit that referenced this pull request Jan 31, 2023
* relax type constraints in BltBufferStrategy.getDrawGraphics
vprovodin pushed a commit that referenced this pull request Feb 1, 2023
* relax type constraints in BltBufferStrategy.getDrawGraphics
vprovodin pushed a commit that referenced this pull request Feb 2, 2023
* relax type constraints in BltBufferStrategy.getDrawGraphics
vprovodin pushed a commit that referenced this pull request Feb 3, 2023
* relax type constraints in BltBufferStrategy.getDrawGraphics
vprovodin pushed a commit that referenced this pull request Feb 4, 2023
* relax type constraints in BltBufferStrategy.getDrawGraphics
vprovodin pushed a commit that referenced this pull request Feb 5, 2023
* relax type constraints in BltBufferStrategy.getDrawGraphics
vprovodin pushed a commit that referenced this pull request Feb 6, 2023
* relax type constraints in BltBufferStrategy.getDrawGraphics
vprovodin pushed a commit that referenced this pull request Feb 7, 2023
* relax type constraints in BltBufferStrategy.getDrawGraphics
vprovodin pushed a commit that referenced this pull request Feb 8, 2023
* relax type constraints in BltBufferStrategy.getDrawGraphics
vprovodin pushed a commit that referenced this pull request Feb 9, 2023
* relax type constraints in BltBufferStrategy.getDrawGraphics
vprovodin pushed a commit that referenced this pull request Feb 10, 2023
* relax type constraints in BltBufferStrategy.getDrawGraphics
vprovodin pushed a commit that referenced this pull request Feb 11, 2023
* relax type constraints in BltBufferStrategy.getDrawGraphics
vprovodin pushed a commit that referenced this pull request Feb 12, 2023
* relax type constraints in BltBufferStrategy.getDrawGraphics
vprovodin pushed a commit that referenced this pull request Dec 4, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 5, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 6, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 7, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 8, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 9, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
mkartashev pushed a commit that referenced this pull request Dec 9, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
mkartashev pushed a commit that referenced this pull request Dec 9, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
mkartashev pushed a commit that referenced this pull request Dec 9, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
mkartashev pushed a commit that referenced this pull request Dec 9, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
mkartashev pushed a commit that referenced this pull request Dec 9, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 10, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
NikitkoCent pushed a commit that referenced this pull request Dec 10, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
NikitkoCent pushed a commit that referenced this pull request Dec 10, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 11, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 12, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 13, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 14, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 15, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 16, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 17, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 18, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 19, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 20, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 21, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 22, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 23, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 24, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 25, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
vprovodin pushed a commit that referenced this pull request Dec 26, 2024
* relax type constraints in BltBufferStrategy.getDrawGraphics

(cherry picked from commit 715b615)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants