This repository has been archived by the owner on Aug 5, 2024. It is now read-only.
[feature] create BEP connection on demands instead of keeping it as a service #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Significantly reduces memory footprint of the application, because the
never-cleaned BepServer instance was holding a
BepOutputBuilder bepOutputBuilder
field which in turn was holding all BEP messages that has been received since the
prevous build.
So the reason for this change is:
in particular because it's easy to make a mistake of keeping too much data.
Memory footprint comparison
The heap size in of this app in idle, for a project containing 2000 targets, is reduced from
more than ~2GB to ~0.5GB.
Bazel BSP 2.5.1 (idle, after 2000k targets import)
Bazel BSP now:
Formatting
Seems like the CI "format" job fails for this commit, but it's unrelated to the changes included in this PR. Should be addressed in a separate PR