This repository has been archived by the owner on Aug 5, 2024. It is now read-only.
[feature] Resolve Scala SDK independently for each target #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aszady
force-pushed
the
independent
branch
4 times, most recently
from
b5f47c0
to
42964ad
Compare
abrams27
reviewed
Apr 12, 2024
aszady
force-pushed
the
independent
branch
2 times, most recently
from
6ce8e91
to
8a69c95
Compare
abrams27
reviewed
Apr 15, 2024
...r/src/main/kotlin/org/jetbrains/bsp/bazel/server/sync/languages/scala/ScalaLanguagePlugin.kt
Outdated
Show resolved
Hide resolved
This prepares us for changes in `rules_scala` that will allow customizing the Scala version for each target. In order to achieve that, we can no longer resolve the Scala SDK globally as the maximal version used. We need to use per-target info. Scala SDK will be still discovered based on the compiler class path. Now though we will look into an implicit dependency of each target, the `_scalac`. This change is backward-compatible, as the mentioned data is already available. It is also forward-compatible with the anticipated cross-build feature of `rules_scala`. (see: bazelbuild/rules_scala#1290) The aspect will produce additional data – namely few compiler classpath jars per Scala target. Perhaps we could review this change in the future to normalize the data back. Now it's not possible, as the data about alternative configurations (here: of scalac) is discarded in the server.
I prepared a small test/example here: aszady/bazel-bsp@independent...aszady:bazel-bsp:independent-test |
|
ohh perfect! seems to work for me as well, can i ask you to add this test to e2e tests as well? looks like a useful scenario to keep there, once it's done i think we will be ready to merge |
|
The problem is, the feature is not yet fully merged into |
|
oh yea sure |
|
is it ready to merge? |
|
Yes, I believe so. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares us for changes in
rules_scalathat will allow customizing the Scala version for each target.In order to achieve that, we can no longer resolve the Scala SDK globally as the maximal version used. We need to use per-target info.
Scala SDK will be still discovered based on the compiler class path.
Now though we will look into an implicit dependency of each target, the
_scalac.This change is backward-compatible, as the mentioned data is already available.
It is also forward-compatible with the anticipated cross-build feature of
rules_scala.(see: bazelbuild/rules_scala#1290)
The aspect will produce additional data – namely few compiler classpath jars per Scala target.
Perhaps we could review this change in the future to normalize the data back. Now it's not possible, as the data about alternative configurations (here: of scalac) is discarded in the server.