Skip to content

Commit

Permalink
Rename InputEventExtended to InputEvent
Browse files Browse the repository at this point in the history
  • Loading branch information
Schahen committed Nov 8, 2024
1 parent 8ce4bd1 commit ea82e51
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ internal class BackingTextArea(
onEditCommand(listOf(CommitTextCommand(evt.data, 1)))
}

override fun onInputInsertLineBreak(evt: InputEventExtended) {
override fun onInputInsertLineBreak(evt: InputEvent) {
if (imeOptions.singleLine) {
onImeActionPerformed(imeOptions.imeAction)
}
Expand All @@ -90,12 +90,12 @@ internal class BackingTextArea(
This event is used for processing events typed via virtual keyboard
on mobile devices
*/
override fun onInputInsertText(evt: InputEventExtended) {
override fun onInputInsertText(evt: InputEvent) {
val data = evt.data ?: return
onEditCommand(listOf(CommitTextCommand(data, 1)))
}

override fun onInputDeleteContentBackward(evt: InputEventExtended) {
override fun onInputDeleteContentBackward(evt: InputEvent) {
processKeyboardEvent(
KeyboardEvent(
"keydown",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package androidx.compose.ui.platform

import org.w3c.dom.events.CompositionEvent
import org.w3c.dom.events.Event
import org.w3c.dom.events.EventTarget
import org.w3c.dom.events.KeyboardEvent

Expand All @@ -29,13 +30,13 @@ internal interface DomInputListener {
fun onKeyDown(evt: KeyboardEvent) {}
fun onKeyUp(evt: KeyboardEvent) {}

fun onInputInsertLineBreak(evt: InputEventExtended) {}
fun onInputInsertCompositionText(evt: InputEventExtended) {}
fun onInputInsertText(evt: InputEventExtended) {}
fun onInputDeleteContentBackward(evt: InputEventExtended) {}
fun onInputInsertLineBreak(evt: InputEvent) {}
fun onInputInsertCompositionText(evt: InputEvent) {}
fun onInputInsertText(evt: InputEvent) {}
fun onInputDeleteContentBackward(evt: InputEvent) {}

// we end up here only if inputType was unprocessed by any of onInput events above
fun onInputUnprocessed(evt: InputEventExtended) {}
fun onInputUnprocessed(evt: InputEvent) {}
}

internal class DomInputService(private val backingElement: EventTarget, private val inputListener: DomInputListener) {
Expand All @@ -52,7 +53,7 @@ internal class DomInputService(private val backingElement: EventTarget, private
backingElement.addEventListener("compositionend", { inputListener.onCompositionEnd(it as CompositionEvent) })

backingElement.addEventListener("input", { evt ->
evt as InputEventExtended
evt as InputEvent

when (evt.inputType) {
"insertLineBreak" -> inputListener.onInputInsertLineBreak(evt)
Expand All @@ -66,7 +67,7 @@ internal class DomInputService(private val backingElement: EventTarget, private
}
}

internal external interface InputEventExtended {
internal external class InputEvent : Event {
val inputType: String
val data: String?
}

0 comments on commit ea82e51

Please sign in to comment.