iOS a11y dialogues and popups integration #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima-avdeev-jb
changed the title
MatkovIvan
requested changes
Feb 9, 2024
| @@ -155,10 +156,20 @@ actual fun Dialog( | |||
| } else { | |||
| null | |||
| } | |||
|
|
|||
| val onEscapeEvent = if (properties.dismissOnBackPress || properties.dismissOnClickOutside) { | |||
There was a problem hiding this comment.
It should not depend on dismissOnClickOutside
There was a problem hiding this comment.
It should, that's basically the semantics of the action.
There was a problem hiding this comment.
It's a public API, dump should be regenerated
| * NOTE: Later this function can be used for root scene layer to perform contextual escape, such | ||
| * as a navigation pop. | ||
| */ | ||
| fun setEscapeEventListener( |
There was a problem hiding this comment.
It doesn't seem required to expose this method to public API. It duplicates existing functionality of other event handlers.
|
@elijah-semyonov I suggest you just generate Esc key event without changing of current APIs / dialogs implementation |
dima-avdeev-jb
approved these changes
Feb 9, 2024
|
@elijah-semyonov You should run |
elijah-semyonov
force-pushed
the
es/ios-a11y-dialogues-and-popus
branch
from
3fc414f
to
d1c43c6
Compare
MatkovIvan
approved these changes
Feb 12, 2024
MatkovIvan
reviewed
Feb 12, 2024
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.desktop.kt
Outdated
Show resolved
Hide resolved
dima-avdeev-jb
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Integrate popup and dialogues with a11y.
AddsetEscapeEventListenertoComposeSceneLayerfor semantic escape, aka "get me out of here if possible"-action incoming from accessibility-based input.Mimic keyboard ESC press on accessibility escape call.
Testing
Test: N/A