Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger fling callbacks on mouse wheel scroll #1100

Merged
merged 7 commits into from
Feb 14, 2024

Conversation

MatkovIvan
Copy link
Member

@MatkovIvan MatkovIvan commented Feb 14, 2024

Proposed Changes

  • Based on Fix nested scrolling on mouse wheel #1055
  • Trigger onScrollStopped callback after mouse wheel scroll
  • Ignore ScrollableDefaultFlingBehaviors during mouse scroll to avoid breaking changes
  • Remove scrolling via dispatchRawDelta, isSmoothScrollingEnabled = false will just disable animation instead
  • Add pager test page in mpp demo

Testing

Test: run pager page in mpp demo

Issues Fixed

Fixes JetBrains/compose-multiplatform#3447
Fixes JetBrains/compose-multiplatform#3454

Base automatically changed from ivan.matkov/fix-nested-scroll to jb-main February 14, 2024 13:55
@MatkovIvan MatkovIvan merged commit 9a39a79 into jb-main Feb 14, 2024
6 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/fix-mouse-fling branch February 14, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rememberSnapFlingBehavior does not snap on desktop when using a scroll wheel Desktop pager physics
3 participants