Fix Pager
direction detection for mouse wheel
#1103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Pager
usesupDownDifference
as a source of a scrolling direction that is not correct in the case of mouse wheel scrolling. This PR adds fallback to a velocity direction if drag distance is zero.Testing
Test: try to scroll back
Pager
in mppBefore
pager_before.mp4
After
pager_after.mp4