-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OS logging integrated with trace
for iOS
#1140
Changes from 7 commits
bd01722
9e31136
5d7ba23
41dbd87
a158f20
8f33b47
0e3165a
0a6a45e
a2b8769
e72cb33
8171bb0
d30099d
0571e97
efdc56f
42cf270
0fc7c34
bebcfc4
8af1ac5
0a8999a
9695ea1
02f7be7
ba137e1
9a75279
96ea8ee
806d73e
5fa15f6
d9df692
ee4adeb
1cbaaa8
b2951f5
7f279e9
93cd6e7
5d703c9
5f26c26
af98cef
c5735e4
b345cba
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,4 +39,5 @@ internal actual object Trace { | |
*/ | ||
actual fun endSection(token: Any?) { | ||
} | ||
|
||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,17 @@ | ||
// | ||
// Use this file to import your target's public headers that you would like to expose to Swift. | ||
// | ||
/* | ||
* Copyright 2024 The Android Open Source Project | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
#import "CMPUIKitUtils.h" |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -75,7 +75,7 @@ internal abstract class BaseComposeScene( | |
private set | ||
|
||
private var isInvalidationDisabled = false | ||
private inline fun <T> postponeInvalidation(crossinline block: () -> T): T { | ||
private inline fun <T> postponeInvalidation(crossinline block: () -> T): T = trace("BaseComposeScene:postponeInvalidation") { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's called from multiple places. Let's add label for trace in parameters of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
check(!isClosed) { "ComposeScene is closed" } | ||
isInvalidationDisabled = true | ||
return try { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same - you should combine js and wasmJs into one file/sourceset - webMain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done