Fix nested scroll when Pager involved in scrolling process #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… perpendicular direction
MatkovIvan
reviewed
Mar 1, 2024
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/Pager.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
approved these changes
Mar 1, 2024
copybara-service bot
pushed a commit
to androidx/androidx
that referenced
this pull request
Mar 4, 2024
Upstreaming JetBrains#1154 fix Bug: 327687953 Test: run `nestedScrollContent_shouldPropagateCrossAxisUnconsumedFlings` test Change-Id: I39287f09161f9775665fb45ad4075954cfac5032
igordmn
pushed a commit
that referenced
this pull request
Mar 27, 2024
Upstreaming #1154 fix Bug: 327687953 Test: run `nestedScrollContent_shouldPropagateCrossAxisUnconsumedFlings` test (cherry picked from https://android-review.googlesource.com/q/commit:9083dbe9cb097ef39adaa5ff23533b526fd70309) Merged-In: I39287f09161f9775665fb45ad4075954cfac5032 Change-Id: I39287f09161f9775665fb45ad4075954cfac5032
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix scroll interruption by Pager component when the scroll happens in perpendicular direction
Proposed Changes
Do not interrupt scrolling if it occurs in a perpendicular direction to the Pager.
Testing
Test: see description here: JetBrains/compose-multiplatform#4395
Issues Fixed
Fixes: The bug on JetBrains/compose-multiplatform#4395