[a11y] Pass the id of the node whose layout changed to accessibility controllers #1162
Conversation
…controllers, rather than simply call onSemanticsChange.
| * Note that the id, rather than the [LayoutNode] itself, is passed here because | ||
| * [LayoutNode] is an internal type, so it can't be exposed in a public method. | ||
| */ | ||
| fun onLayoutChange(semanticsOwner: SemanticsOwner, semanticsNodeId: Int) |
There was a problem hiding this comment.
We already discussed this with @elijah-semyonov and as far as I remember we decided to introduce optional second parameter to onSemanticsChange instead of adding a new callback
There was a problem hiding this comment.
Having it in a separate function adds more information; namely that only the bounds of the node have changed, and not any semantic properties.
There was a problem hiding this comment.
The API changed here isn't public, by the way, so no need for the "changes in API" tag.
There was a problem hiding this comment.
it's public but with "internal" annotation. The rule for tag is basically - "changes in desktop/ui.api file".
I'd apply the rule regarding two reviewers here
There was a problem hiding this comment.
I disagree. @internalapi implies that it's internal, and only technically public because of the limitations of the language. We don't make any compatibility guarantees about such code.
There was a problem hiding this comment.
ok, it's not a big deal in this case
| * Note that the id, rather than the [LayoutNode] itself, is passed here because | ||
| * [LayoutNode] is an internal type, so it can't be exposed in a public method. | ||
| */ | ||
| fun onLayoutChange(semanticsOwner: SemanticsOwner, semanticsNodeId: Int) |
There was a problem hiding this comment.
ok, it's not a big deal in this case
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt
Show resolved
Hide resolved
Currently, when the layout of a single node changes, we call onSemanticsChange on (desktop)
AccessibilityControllerand (iOS)AccessibilityMediator, which causes them to re-sync the entire node tree.Proposed Changes
Pass the semantics id of the node whose layout changed to the accessibility controllers, so they can invalidate the tree more granularly. Note that this PR only passes the information; the actual granular handling will be done in separate PR(s).
Testing
Test: Manually, only on the desktop.